Fix #62: fix claims for complex and weird paths #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kcajmagic
commented
Aug 9, 2018
kcajmagic
commented
- fixes issue Claims Validation Error #62
- update handling of paths by parsing it through the url package
- added tests to validate claims and weird paths
- fixes issue xmidt-org#62 - update handling of paths by parsing it through the url package - added tests to validate claims and weird paths
kcajmagic
changed the title
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 68.24% 68.33% +0.08%
==========================================
Files 174 174
Lines 11475 11478 +3
==========================================
+ Hits 7831 7843 +12
+ Misses 2907 2896 -11
- Partials 737 739 +2
Continue to review full report at Codecov.
|
kcajmagic
changed the title
- default is false
njharter
reviewed
Aug 9, 2018
secure/validator_test.go
Outdated
| if path, ok = record.context.Value("path").(string); ok { | ||
| path = record.context.Value("path").(string) | ||
| } | ||
| fmt.Printf("ctx method: %s, ctx path: %s, claims: %v, expectedValid: %v\n", method, path, record.claims, record.expectedValid) |
|
Since we're deprecating/removing the secure package, I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.